Skip to content

fix: handle missing gh executable - #26

Open
giscebot wants to merge 1 commit into
mainfrom
fix/issue-25-gh-not-found
Open

fix: handle missing gh executable#26
giscebot wants to merge 1 commit into
mainfrom
fix/issue-25-gh-not-found

Conversation

@giscebot

Copy link
Copy Markdown
Collaborator

Closes #25.

Summary

  • convert a missing configured gh executable into a CompletedProcess-style failure with exit code 127
  • keep GitHub follow-up paths from crashing the worker on FileNotFoundError
  • add regression coverage for live mode

Tests

  • .venv/bin/pytest -q tests/test_modes_cli.py (10 passed)
  • .venv/bin/pytest -q (154 passed, 5 unrelated monitor failures caused by the live upstream v0.58.0 release check versus local package v0.18.7)

Requested by: automated Sentry alert #25; no human requester was present.

@ecarreras

Copy link
Copy Markdown
Member

@giscebot always open pull-requests to the main repositori if this is a fork

@giscebot

Copy link
Copy Markdown
Collaborator Author

Correcte. Ho he verificat: gisce/github-agent-bridge és un fork de pilipilisbot/github-agent-bridge i aquest PR s'ha obert erròniament contra el fork. No hi ha cap PR equivalent obert a upstream.

El destí correcte és pilipilisbot/github-agent-bridge:main, amb head gisce:fix/issue-25-gh-not-found. El patch actual és acotat (client de GitHub + test de regressió) i tests/test_modes_cli.py passa: 10/10.

Aquest torn és de revisió i no em permet crear/moure/tancar PRs; per tant, el següent pas és obrir el PR contra upstream i després tancar el #26 com a duplicat. Mantindré aquesta regla per als PRs futurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FileNotFoundError: [Errno 2] No such file or directory: 'gh'

2 participants