Repository navigation
Adds Microsoft APM to package-manager reporting and dependency discovery. - #250
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
knowledge/_shared/apm.toml: shared tool definition with categorypackage_manager, install commandapm installandapm.yml,apm.lock.yamlandapm.lockas detection and config paths. It has noecosystemskey, so detection does not depend on Python or any other language.knowledge/_shared/_manifests.toml: adds the three files to dependency discovery. They are parsed by the APM parser in manifests v0.14.0 (Parse APM manifests and lockfiles manifests#136).github.com/git-pkgs/rolesto v0.1.4 for the APM rules from Classify APM manifests, lockfiles and installed modules roles#14, so content underapm_modules/is excluded from project evidence.Changed-file scans need no new code: the files are in the manifest list and the tool's detect files, so the existing manifest and file-match checks recheck APM.
Tests
detect/apm_test.goruns through the detection engine:apm.yml) and lockfile-only (apm.lock.yaml, legacyapm.lock) fixtures: APM is detected, the file is reported as anapmmanifest and its dependency is extractedapm_modules/are excluded from project files, manifests and dependencies (this fails on roles v0.1.3)FilterByChangedFileskeeps itSummary by CodeRabbit