fix(PlayerUpdates): upstream-compatible rewrites for AC master - #28
fix(PlayerUpdates): upstream-compatible rewrites for AC master#28Thapza888 wants to merge 3 commits into
Conversation
…t, weather, visibility - Cinematic: replace manual _cinematicMgr->m_cinematicDiff tracking with _cinematicMgr.UpdateCinematic(p_time) single-call pattern - HostileRefMgr: migrate getHostileRefMgr().deleteReferencesOutOfRange() to GetCombatManager().EndCombatBeyondRange() - Weather: replace WeatherMgr::FindWeather/AddWeather pattern with GetMap()->GetOrGenerateZoneDefaultWeather() + SendZoneDynamicInfo() - VisibleNotifier: consolidate two-pass large/non-large visitor into single notifier with VisitFarVisibleObjects - VisitObjects: migrate m_seer-based Cell::VisitObjects to explicit sight-position/map parameter overload fix(FactionFree.sql): remove scale column from creature_template INSERT AC master removed the scale column from creature_template schema. Both Quinley Gearspark and Harleen Gearspark INSERTs updated.
Fails to build |
The method is declared as virtual in Unit.h and overridden in Player.h, but its implementation was in the core's PlayerUpdates.cpp. Since this module replaces the core file, the implementation was stripped out, causing a linker error: undefined reference to Player::AtExitCombat() Copied the implementation from AC master exactly: - Calls Unit::AtExitCombat() - Calls UpdatePotionCooldown() - Resets DK rune grace periods on combat exit
|
Fix pushed — added missing Player::AtExitCombat() implementation. Root cause: The method is declared virtual in Unit.h and overridden in Player.h, but its implementation lived in the core's PlayerUpdates.cpp. Since this module replaces that file at build time, the implementation was stripped, causing a linker error. Added the implementation matching AC master exactly (calls Unit::AtExitCombat, UpdatePotionCooldown, and resets DK rune grace periods). Should build clean now — please retry. |
|
the FactionFree.sql seems to have an incorrect column or something? That's causing an error at server run. |
…hanges The March 22, 2026 AC update altered creature_template: - DROPPED scale (handled in prior commit) - DROPPED mechanic_immune_mask - DROPPED spell_school_immune_mask - ADDED CreatureImmunitiesId (default 0) Updated both INSERT column lists and value rows accordingly.
|
Fixed the SQL too. Root cause: the March 22, 2026 AC master update altered \creature_template:
Both INSERT statements now use \CreatureImmunitiesId\ instead of the two dropped columns, with value 0. Should resolve the SQL error on server start. |
2 participants
Summary
Five compatibility fixes in PlayerUpdates.cpp to align with AzerothCore master API changes, plus a schema alignment in FactionFree.sql.
PlayerUpdates.cpp
FactionFree.sql
Files: 2 changed, +12/−33