fix: resolve build and SQL errors for AzerothCore main (PlayerUpdates.cpp, SQL schema) [FaaFyfxR9WAQrL7FcAgEHJvztd8cVMxvjHRS55rw1nwH] - #32
Open
waterWang wants to merge 1 commit into
Conversation
….cpp, SQL schema)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for Issue #27
This PR fixes two categories of errors preventing the module from compiling and running on the latest AzerothCore main branch.
Fix 1: C++ Build Errors (PlayerUpdates.cpp)
a) CinematicMgr (lines 73-77):
_cinematicMgris now stored by value in modern AzerothCore, not by pointer. Changed->to.for all member accesses.b) getHostileRefMgr() (line 404): Renamed to
GetHostileRefMgr()(capital G) per modern AzerothCore API.c) WeatherMgr (lines 1291-1298): The weather API has changed.
WeatherMgr::FindWeather()andWeatherMgr::AddWeather()no longer exist. Replaced withWeatherMgr::GetWeatherData()+sWorld->FindWeather()pattern.d) VisibleNotifier (lines 1605-1615):
VisibleNotifierconstructor now takes only(const WorldObject&).VISIBILITY_INC_FOR_GOBJECTSno longer exists. Replaced the two-pass notifier with a single-passAcore::VisibleNotifier+Cell::VisitObjectscall.Fix 2: SQL Schema Errors
EntryChecker_RUN_FIRST.sql: Changed
id1column reference toidin thecreaturetable SELECT query — the column is namedid, notid1, in modern AzerothCore.FactionFree.sql:
INSERTstatements for thecreaturetable changed\id1`to`id`` to match the actual schema.creature_templateINSERT statements had the\scale`` column removed (column no longer exists in modern AzerothCore creature_template schema).