Skip to content

fix: resolve build and SQL errors for AzerothCore main (PlayerUpdates.cpp, SQL schema) [FaaFyfxR9WAQrL7FcAgEHJvztd8cVMxvjHRS55rw1nwH] - #32

Open
waterWang wants to merge 1 commit into
gitdalisar:mainfrom
waterWang:main
Open

fix: resolve build and SQL errors for AzerothCore main (PlayerUpdates.cpp, SQL schema) [FaaFyfxR9WAQrL7FcAgEHJvztd8cVMxvjHRS55rw1nwH]#32
waterWang wants to merge 1 commit into
gitdalisar:mainfrom
waterWang:main

Conversation

@waterWang

Copy link
Copy Markdown

Fixes for Issue #27

This PR fixes two categories of errors preventing the module from compiling and running on the latest AzerothCore main branch.

Fix 1: C++ Build Errors (PlayerUpdates.cpp)

a) CinematicMgr (lines 73-77): _cinematicMgr is now stored by value in modern AzerothCore, not by pointer. Changed -> to . for all member accesses.

b) getHostileRefMgr() (line 404): Renamed to GetHostileRefMgr() (capital G) per modern AzerothCore API.

c) WeatherMgr (lines 1291-1298): The weather API has changed. WeatherMgr::FindWeather() and WeatherMgr::AddWeather() no longer exist. Replaced with WeatherMgr::GetWeatherData() + sWorld->FindWeather() pattern.

d) VisibleNotifier (lines 1605-1615): VisibleNotifier constructor now takes only (const WorldObject&). VISIBILITY_INC_FOR_GOBJECTS no longer exists. Replaced the two-pass notifier with a single-pass Acore::VisibleNotifier + Cell::VisitObjects call.

Fix 2: SQL Schema Errors

EntryChecker_RUN_FIRST.sql: Changed id1 column reference to id in the creature table SELECT query — the column is named id, not id1, in modern AzerothCore.

FactionFree.sql:

  • All INSERT statements for the creature table changed \id1`to`id`` to match the actual schema.
  • Both creature_template INSERT statements had the \scale`` column removed (column no longer exists in modern AzerothCore creature_template schema).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant