Skip to content

Use default request options instead of undefined#4030

Merged
mbg merged 1 commit into
mainfrom
mbg/fix/no-proxy
Jul 22, 2026
Merged

Use default request options instead of undefined#4030
mbg merged 1 commit into
mainfrom
mbg/fix/no-proxy

Conversation

@mbg

@mbg mbg commented Jul 22, 2026

Copy link
Copy Markdown
Member

Fixes a potential regression introduced by #4007 since Octokit doesn't treat request: undefined equivalently to no request key in the options.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Advanced setup - Impacts users who have custom CodeQL workflows.
  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Other first-party - The changes impact other first-party analyses.
  • Third-party analyses - The changes affect the upload-sarif action.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
  • GHES - Impacts CodeQL workflows on GitHub Enterprise Server.

How did/will you validate this change?

  • Test repository - This change will be tested on a test repository before merging.
  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg self-assigned this Jul 22, 2026
Copilot AI review requested due to automatic review settings July 22, 2026 04:57
@mbg
mbg requested a review from a team as a code owner July 22, 2026 04:57
@github-actions github-actions Bot added the size/XS Should be very easy to review label Jul 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

  • Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.

Pull request overview

Preserves Octokit’s default request behavior when no registry proxy is configured.

Changes:

  • Uses githubUtils.defaults.request instead of undefined.
  • Updates the generated JavaScript bundle.
Show a summary per file
File Description
src/api-client.ts Preserves default Octokit request options.
lib/entry-points.js Generated bundle; excluded from review by policy.

Review details

Files excluded by content exclusion policy (1)
  • lib/entry-points.js
  • Files reviewed: 1/2 changed files
  • Comments generated: 1
  • Review effort level: Medium

Comment thread src/api-client.ts
@mbg
mbg merged commit 72f6a9d into main Jul 22, 2026
226 checks passed
@mbg
mbg deleted the mbg/fix/no-proxy branch July 22, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants