C++: Update expected test results after extractor changes - #21897
Merged
Conversation
jketema
added
the
depends on internal PR
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the C++ QL library test expectation output for the friends/loop test to match recent extractor behavior, ensuring the regression test remains stable and accurate.
Changes:
- Refreshes
friends.expectedentries (added/removed rows) to reflect updated friend relationships being reported. - Adjusts reported source ranges (e.g.,
5:26:5:26→5:26:5:29, similarly on line 10) consistent with extractor span changes.
Show a summary per file
| File | Description |
|---|---|
| cpp/ql/test/library-tests/friends/loop/friends.expected | Updates expected test output rows and ranges to align with extractor changes. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
IdrissRio
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.