Unified: Extract init keywords - #22641
Merged
Merged
Conversation
hvitved
force-pushed
the
unified/constructor-name-node
branch
from
September 21, 2026 18:38
b9962e5 to
d89d9e2
Compare
hvitved
marked this pull request as ready for review
September 21, 2026 18:55
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused mapping change is consistent with the AST schema and covered by updated generated expectations.
Review effort: Balanced
Findings: None
What changed in this PR
Extracts Swift init keywords as constructor name nodes, enabling future constructor-call resolution.
Changes:
- Maps
initializerDecl.initKeywordtoconstructor_declaration.name_node. - Updates generated extractor and control-flow expectations.
| File | Description |
|---|---|
unified/extractor/src/languages/swift/swift.rs |
Extracts the init keyword as an identifier. |
unified/extractor/tests/corpus/swift/types/constructor-with-parameters.output |
Updates generated constructor output. |
unified/extractor/tests/corpus/swift/types/class-with-initializer.output |
Updates generated initializer output. |
unified/ql/test/library-tests/controlflow/cfg.swift |
Marks new initializer identifiers as intentionally absent from CFGs. |
unified/ql/test/library-tests/controlflow/cfg.expected |
Updates generated control-flow expectations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
asgerf
approved these changes
Sep 22, 2026
Contributor
There was a problem hiding this comment.
LGTM. Bug is tracked here https://github.com/github/codeql-team/issues/4882 Nevermind this was a different bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful for resolving
super.initcalls, which can then be handled like any other call.