fix(templates): guard constitution command scope#3616
Draft
BenBtg wants to merge 3 commits into
Draft
Conversation
Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 02f9e138-da58-4a60-93b9-eae659d2aa19
Contributor
There was a problem hiding this comment.
Pull request overview
Adds governance-only scope safeguards to the constitution command.
Changes:
- Defers implementation requests to suggested follow-up commands.
- Adds regression coverage for the rendered guard.
Show a summary per file
| File | Description |
|---|---|
templates/commands/constitution.md |
Adds scope and follow-up guidance. |
tests/integrations/test_integration_generic.py |
Verifies rendered guard content. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Medium
Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 02f9e138-da58-4a60-93b9-eae659d2aa19
Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 02f9e138-da58-4a60-93b9-eae659d2aa19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The constitution command could interpret mixed governance and implementation requests as permission to modify application artifacts. This adds an explicit governance-only scope guard, preserves out-of-scope intent as suggested follow-up commands, and renders those suggestions using each skills integration's native
$speckit-*invocation syntax.Closes #896
Testing
uv run specify --helpuv sync && uv run pytest.venv/bin/python -m pytest tests/integrations/test_integration_generic.py -qAI Disclosure
This change and PR were authored autonomously on behalf of @BenBtg by GitHub Copilot (model: GPT-5.6 Sol).