[bug-fix] Fix specify-step-self-reference: renumber duplicate step 6 in specify.md#3618
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
Apply the remediation from the bug assessment on issue #2407. The top-level numbered list in templates/commands/specify.md had two consecutive items both labelled 6. — the execution-flow step (line 117) and the write-spec step (line 142). This caused the Specification Quality Validation section to be numbered 7 when it should be 8, which led to a self-referencing 'proceed to step 7' instruction inside step 7 itself. Changes: - Line 142: 6. Write the specification → 7. Write the specification - Line 144: 7. Specification Quality Validation → 8. Specification Quality Validation - Add regression test tests/test_specify_template_numbering.py that asserts the main execution list is sequential with no duplicates Refs #2407 Assisted-by: GitHub Copilot (model: claude-sonnet-4.6, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix — specify-step-self-reference
Proposed fix for issue #2407, applying the remediation from the bug assessment.
Verdict: Valid · Severity: low
Summary
templates/commands/specify.mdcontained two consecutive top-level list items both numbered6.— the "Follow this execution flow" step and the "Write the specification" step. This caused the "Specification Quality Validation" section to appear as step 7 when it should be step 8, which historically produced a self-referencingproceed to step 7instruction inside the step already labelled 7.Changes
templates/commands/specify.md6.(write-spec step) →7.and7.(quality-validation step) →8.tests/test_specify_template_numbering.pyTests Added or Updated
tests/test_specify_template_numbering.py::test_no_duplicate_top_level_ordinals— pins that the main list has no duplicate ordinal numberstests/test_specify_template_numbering.py::test_main_execution_list_is_sequential— pins that the steps run 1, 2, 3, ... N without gapsLocal Verification
python3 -c ...— main execution ordinals resolved to[1, 2, 3, 4, 5, 6, 7, 8], which is sequential.presets/lean/,presets/scaffold/,presets/self-test/) are all ≤23-line stubs and do not embed the numbered list; no changes required there.Deviations from Assessment
None. The preferred (root-cause) remediation from the assessment was applied exactly as described (renumber line 142 from
6.to7.and line 144 from7.to8.). A regression test was added as the assessment recommended.Risks & Review Notes
proceed to step 7→proceed to the Mandatory Post-Execution Hooks section) was already shipped in an earlier commit; this PR applies the structural root-cause fix only.Refs #2407 · cc
@BigBandaid2