Repository navigation
test(sonar): document platform-conditional test skips (typescript:S1607) - #208
Merged
Merged
Conversation
SonarQube rule typescript:S1607 flags the conditional test.skip() calls as ignored tests. Both are deliberate cross-platform guards - the macOS all-workspaces and Windows tray-overflow regressions can only run on their own platform - so NOSONAR markers explain why instead of removing them.
setchy
changed the title
setchy
marked this pull request as ready for review
October 7, 2026 12:15
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The two
test.skip(condition, ...)calls inmenubar.e2e.test.tsare intentional cross-platform guards:isVisibleOnAllWorkspaces),Rather than deleting platform-specific coverage, a
NOSONAR:typescript:S1607marker now documents why each skip exists.Findings