Repository navigation
refactor(sonar): mark constructor-only fields readonly (typescript:S2933) - #218
Merged
Merged
Conversation
SonarQube rule typescript:S2933 flags class members that are only assigned in the constructor. _app and _options are set once in the constructor and never reassigned, so they are now readonly.
setchy
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_appand_optionsinsrc/Menubar.tsare assigned only in the constructor and never reassigned (only their properties mutate viasetOptionetc.). They are nowreadonly.Findings