Repository navigation
fix(sonar): invoke capture tools by absolute path (typescript:S4036) - #225
Merged
Merged
Conversation
SonarQube rule typescript:S4036 flags execFileSync calls that resolve executables through a potentially writable PATH. The screen-capture, PowerShell, grim and import invocations now use their fixed install locations so resolution is deterministic.
setchy
changed the title
setchy
marked this pull request as ready for review
October 4, 2026 03:34
setchy
marked this pull request as draft
October 4, 2026 22:22
setchy
marked this pull request as ready for review
October 7, 2026 12:15
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/visual/run.mtsspawned system binaries (screencapture,powershell,sh,grim,import) via PATH lookup, which ruletypescript:S4036flags when the PATH is mutable. All six calls now use their fixed install locations:/usr/sbin/screencapture%SystemRoot%\System32\WindowsPowerShell\v1.0\powershell.exe/bin/sh/usr/bin/grim/usr/bin/importFindings