Skip to content

v1.9.2: CLAUDE.md §0 — branch, PR and approval workflow - #5

Merged
gitluis merged 4 commits into
masterfrom
docs-branch-pr-workflow
Oct 25, 2026
Merged

gitluis merged 4 commits into
masterfrom
docs-branch-pr-workflow

Conversation

@gitluis

@gitluis gitluis commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Stacked on #4 (← #3 ← #2 ← #1). Merge in order. Released as v1.9.2 (docs only).

Summary

This makes the review rule standard. It's written into CLAUDE.md §0, at the top, so every future session reads it first.

The rule

  • One branch and one PR per change:
    • Every new feature, bug fix or major change gets its own branch and its own PR.
    • Minor changes (typos, doc wording, small refactors, housekeeping) may be grouped.
    • Review revisions go on the PR's own branch, not into a new PR.
    • Never commit directly to master.
  • What every PR includes: CHANGELOG and version bump, a description (summary, cause, changes, testing, pre-merge checklist), and tests run.
  • Stacked PRs: branch from the unmerged base, merge forward when the base changes, merge in order.
  • Approval before merging:
    • Either Luis merges or comments approval on GitHub, or approves in chat.
    • For a chat approval, Claude first posts a PR comment recording who, the date, his exact words and a link to the chat, and only then merges.
    • No recorded approval, no merge.
    • New commits after an approval need a fresh one.

Changes

  • CLAUDE.md: new §0, plus the version and last-updated line.
  • Release: CHANGELOG 1.9.2 and version strings.

No code changes.

GitHub enforcement — blocked for now

I tried to turn on branch protection for master with your go-ahead. GitHub refused: "Upgrade to GitHub Pro or make this repository public to enable this feature." Nothing was changed.

Review revision 4bb7da5 records the intended settings in §0 for when it becomes possible:

  • Require a PR with 0 required approvals. You're the PR author, and GitHub won't let an author approve their own PR, so a GitHub approval is a merge or a comment.
  • Block force pushes and deletion.
  • Apply to admins.

https://claude.ai/code/session_01AT1Bh6Sscb8ogzzuf8U3Jc


Generated by Claude Code

Every new feature, bug fix or major change gets its own branch and PR; minor
changes may be grouped. Nothing merges without Luis's approval — on GitHub, or
in chat, recorded as a PR comment (who, date, quoted words, link) before merging.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AT1Bh6Sscb8ogzzuf8U3Jc
…tion

PRs are opened under Luis's account and GitHub doesn't let authors approve
their own PRs, so GitHub approval = merge or approving comment. Branch
protection can't be enabled yet (GitHub Free + private repo); record the
intended settings for when it can.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AT1Bh6Sscb8ogzzuf8U3Jc
@gitluis gitluis removed their assignment Oct 25, 2026
…anch-pr-workflow

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QoR1wxcaDjVVk3xmd5rRCt
Base automatically changed from fix-state-file-boot-dates to master October 25, 2026 05:00
@gitluis

gitluis commented Oct 25, 2026

Copy link
Copy Markdown
Owner Author

Manual test: Edge (InPrivate), sample data only

Branch: docs-branch-pr-workflow (v1.9.2) · Data: the 3 CSVs in samples/ (257 transactions, no API key)

This PR is docs only: CLAUDE.md §0, a CHANGELOG entry, and the version string in README.md, index.html and js/views-settings.js. The two "Merge data-cleanup-and-reset" commits on the branch don't show up in the diff against master, because that work already landed with #3.

# Test Expected Result
1 Read CLAUDE.md §0 Matches the agreed workflow: one branch/PR per change, stacked PRs merge in order, approval on GitHub or recorded from chat, fresh approval after new commits ✅ Pass
2 Sidebar footer v1.9.2 · FinLens ✅ Pass
3 Settings → General FinLens v1.9.2 · 257 transactions loaded ✅ Pass
4 Import the 3 sample CSVs, then open each view Same as master, no crash ✅ Pass
5 Console Nothing new compared with master ✅ Pass

Headless comparison (same 3 CSVs):

  • master: 257 transactions, all 23 views render, 0 console errors, version shows v1.9.1.
  • This branch: 257 transactions, all 23 views render, 0 console errors, version shows v1.9.2 in both places.
  • Diff scope: 5 files, +69 −6. No v1.9.1 strings left outside the CHANGELOG history. Every js/*.js file passes node --check. GitHub reports the PR as mergeable (clean) against master.

Notes

@gitluis
gitluis merged commit 15b4ad1 into master Oct 25, 2026
@gitluis
gitluis deleted the docs-branch-pr-workflow branch October 25, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants