Skip to content

v1.18.1: Add MIT license - #51

Open
gitluis wants to merge 2 commits into
save-status-indicatorfrom
add-mit-license
Open

gitluis wants to merge 2 commits into
save-status-indicatorfrom
add-mit-license

Conversation

@gitluis

@gitluis gitluis commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Stacked on #23 (save-status-indicator, v1.18.0). Merge after #23. It goes at the top of the stack so it doesn't collide with any open PR's version number (#22 already uses v1.10.6 off master).

Summary

Adds an MIT license ahead of making the repository public.

What changed

  • LICENSE (new) — standard MIT text, Copyright (c) 2026 Luis Rivera. GitHub will detect it and show "MIT license" on the repo page.
  • README.md — License: MIT in the header line, and a short License section before the footer.
  • Version v1.18.1 (patch, docs only) in all four places per CLAUDE.md §17: CHANGELOG.md, README.md (header + footer), index.html footer, js/views-settings.js. CLAUDE.md §1 version and the last-updated line too.

No app code changed.

Automated checks: earlier run, not re-run · commit not recorded

Moved unchanged from this PR's "Test results" comment on 2026-11-04; not re-run, so not in the new table format. Originally a description section titled "How it was tested".

  • Checked every version string reads v1.18.1 and none still reads v1.18.0 in the five version spots.
  • No headless run: the only JS/HTML edits are the two version strings.
Manual QA steps

Setup

  1. Open the PR on GitHub and go to Files changed, or run git checkout add-mit-license locally.

1. LICENSE file

  1. On GitHub, switch the file browser to the add-mit-license branch and open LICENSE.

Expected:

  • GitHub shows an MIT license badge above the file (it recognized the text).
  • The copyright line reads Copyright (c) 2026 Luis Rivera.

2. README mentions it, and the link works

  1. Open README.md on the same branch.
  2. Click MIT in the header line, then scroll to the License section near the bottom and click MIT License.

Expected:

  • The header line ends with License: MIT, and both links open the LICENSE file.
  • Header and footer both read v1.18.1.

3. App version

  1. Open index.html in Edge and go to Settings → General.

Expected:

  • Version reads FinLens v1.18.1, and the page footer reads v1.18.1 · FinLens.

Please check before merging

  • Copyright holder is right: Luis Rivera (from the commit author name). Change it if you'd rather use a handle or a different name.
  • Year 2026 is fine (the year the license is added; earlier work in 2026 too).
  • You're OK with MIT's terms: anyone can reuse, modify and sell copies, as long as the notice stays. If you'd want changes shared back, Apache-2.0 or GPL would be alternatives.
  • Manual QA passed in Edge/Chrome with a real folder

Generated by Claude Code


Generated by Claude Code

Add LICENSE (MIT, Copyright (c) 2026 Luis Rivera) ahead of making the
repo public. README links it in the header and gets a License section.
Version bumped in CHANGELOG, README, index.html, views-settings.js and
CLAUDE.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Z8iBViNZdUb4H5tMSg8aP
@gitluis gitluis added chore Housekeeping: cleanup, dead code, licensing documentation Improvements or additions to documentation labels Nov 3, 2026 — with Claude
@gitluis gitluis added this to the Clarity stack (v1.12.0 → v1.18.1) milestone Nov 3, 2026 — with Claude
gitluis pushed a commit that referenced this pull request Nov 4, 2026
Conflicts were the version lines and the top of the CHANGELOG: kept the
stack's content with v2.0.2 and this PR's entry on top.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Z8iBUNj6C627mxmm1CurV
…d-mit-license

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Z8iBUZo6LRYpLthSp2PRi

# Conflicts:
#	js/views-settings.js
@gitluis gitluis changed the title v1.18.1: add MIT license v1.18.1: Add MIT license Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Housekeeping: cleanup, dead code, licensing documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants