Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,17 @@ Format follows [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

---

## [1.10.10] — 2026-11-04

### Technical (docs)
- **Automated checks and manual QA are told apart in PR descriptions.** CLAUDE.md §0 gets a "PR layout" section. Automated checks are the scripted checks run in a sandbox; manual QA is the hand-run script in a collapsed "Manual QA steps" section, recorded by a "Manual QA passed in Edge/Chrome with a real folder" box in "Please check before merging".
- **Automated check results are a collapsed table in the description.** The section's title is the status line (`Automated checks: 6/7 passed · environment · SHA · date`). Inside: a # · Check · Area · Result · Notes table, with long logs in nested collapsed blocks. Skipped rows don't count as passed.
- **When to re-run:** a full run for commits that change the PR's content, a light run (version lines, JS syntax, boot) after a `master` merge or renumber. Each run replaces the section in place, so the SHA in its title shows whether the checks match the latest commit.
- **Open PRs moved to the layout (2026-11-04):** each one's earlier results went, unchanged and not re-run, into a collapsed "Automated checks: earlier run, not re-run" section, and the old "Test results" comments were deleted. Earlier CHANGELOG entries are left as they are.
- Version: v1.10.6–v1.10.9 are already used by open PRs #22, #52, #61, #62 and #63, so this takes v1.10.10. Whichever merges later renumbers if needed (§0).

---

## [1.10.5] — 2026-11-02

### Fixed
Expand Down
43 changes: 40 additions & 3 deletions CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,46 @@ Nothing reaches `master` except through a reviewed pull request. This is the own
### What every PR includes

- **CHANGELOG and version** bumped per §17.
- **A description** with a summary, the cause (for bugs), what changed, how it was tested, and a "please check before merging" list.
- **A description** with a summary, the cause (for bugs), what changed, what wasn't verified, manual QA steps and a "please check before merging" list, laid out as in "PR layout" below.
- **Tests run** before opening the PR (headless browser checks against `samples/`). Report results honestly, including anything not verified.

### PR layout

The description is for context: why the change exists, what caused it and what changed. Reproduction steps, manual QA steps and check results are collapsed so they stay out of the way.

**Two kinds of testing, kept apart:**

| | Automated checks | Manual QA |
|---|---|---|
| **What** | Scripted checks run in a sandbox: syntax, version lines, product rules, headless Chromium against `samples/` | A step-by-step script followed by hand before merging |
| **Where it runs** | Headless browser, fake or no data folder | Real Edge/Chrome with a real data folder |
| **Where it lives** | The collapsed "Automated checks" section, whose title is the status line | The collapsed "Manual QA steps" section |
| **How it's recorded** | ✅ / ❌ / ⏭️ per row in the section's table | The "Manual QA passed" box in "Please check before merging" |

A passing "Automated checks" title means the automated checks passed. It never means manual QA was done.

- **Order of the description:** summary; cause (bug fixes); what changed; any other context (finance notes, trade-offs, findings not fixed); `## Not verified` (what the automated checks couldn't cover, e.g. real Edge/Chrome with a real folder); the collapsed sections; `## Please check before merging` last.
- **Collapsed sections**, closed by default, in this order:
1. **Automated checks.** Its title is the status line: `Automated checks: 6/7 passed · headless Chromium · abc1234 · 2026-11-04`, i.e. ✅ rows out of all rows, the environment, the commit's short SHA and the date. Skipped rows are not counted as passed. Inside:
- a table with the columns **# · Check · Area · Result · Notes**. **Area** is one of Docs, Code, UI, Data, Finance, Rules, Security. **Result** is ✅ Pass, ❌ Fail or ⏭️ Skipped. A failed or skipped row says why in Notes, and every skipped row is also listed under "Not verified";
- long logs below the table, each in its own nested collapsed block named by its row: `<details><summary>Log: 2 — JS syntax</summary>`.
2. **How to reproduce the bug** (bug fixes only).
3. **Manual QA steps**: numbered, each one action plus what should be seen (exact screen, button, value or file), starting from a known state.

Write each as `<details><summary><b>Manual QA steps</b></summary>`, then a blank line, the content, a blank line and `</details>`. Without the blank lines GitHub doesn't render the Markdown inside. When a new commit changes the steps, edit the section in place.
- **"Please check before merging"** always includes `- [ ] Manual QA passed in Edge/Chrome with a real folder`.
- **When to re-run the automated checks.** Each run replaces the "Automated checks" section in place, title included. Past runs stay in the description's edit history.

| Commit | Re-run | Checks |
|---|---|---|
| Changes the PR's own content (code, docs, review fixes) | Yes | Full run |
| Merge of `master`, or a version renumber | Yes | Light run: version lines, JS syntax, boot |
| No commit (description or comment edits only) | No | — |

The SHA in the section's title should always match the branch's latest commit. If it doesn't, the PR hasn't been checked at its current state.
- **Results from before this rule** were moved, unchanged and not re-run, into each open PR's "Automated checks" section on 2026-11-04, titled `Automated checks: earlier run, not re-run · <SHA>` (or `commit not recorded`), and the old "Test results" comments were deleted. They stay in their original free-form format until the PR's next run replaces them with the table.
- The `Generated by` footer stays last in the description.

### Stacked PRs

- **When a change depends on an unmerged PR,** branch from that PR's branch and set it as the new PR's base. Say so at the top of the description.
Expand Down Expand Up @@ -59,7 +96,7 @@ Until then, this section is the rule.

FinLens is a **single-origin, zero-build, vanilla JavaScript personal finance dashboard** that runs entirely in the browser. There is no server, no npm, no bundler, no framework, and no TypeScript. The entry point is `index.html`; everything else is a plain `.js` file in the `js/` folder.

**Current version:** v1.10.5 (updated in `index.html` footer, `README.md`, and `CHANGELOG.md` on every release).
**Current version:** v1.10.10 (updated in `index.html` footer, `README.md`, and `CHANGELOG.md` on every release).

**What it does:** Imports CSV exports from Ally Bank (Checking + Savings) and Chase credit cards, parses and normalizes them into a unified transaction model, and renders a multi-tab financial dashboard with budgeting, debt tracking, savings forecasting, investment planning, and Claude-powered AI analysis.

Expand Down Expand Up @@ -798,7 +835,7 @@ Multiple Chase card files can be loaded simultaneously. Each gets a unique `acco

---

*Last updated: v1.10.5 — 2026-11-02 (no section changes: Import Logs race fix; v1.10.4: §8, §13 single `~` is literal; §21 excerpts escape `~`; v1.10.3: §13 refusals; §21 declined runs; v1.10.2: §13 summary states its dates; §21 per-month derivations; v1.10.1: §13 `AI_MAX_TOKENS`, thinking and cut-off answers; v1.10.0: §21 AI Eval added; §13 `callClaude()` raw mode; v1.9.6: §14 folder access lasts until the last tab closes, not one page load; v1.9.5: §7 chart guard; v1.9.4: views-db.js changelog reads CRLF checkouts; v1.9.3: §14 folder permission: re-request on click, Reconnect banner, browser copy wins; v1.9.2: §0 branch, PR and approval workflow added; v1.9.1: §4.5 rehydrate transactions loaded from JSON; v1.9.0: §20 Data & Reset added; v1.8.1: §10 re-upload dedup rewritten for the occurrence-suffix fix; v1.8.0: AI Analysis restored with API-key and output hardening; `renderMarkdown()` added; `samples/` added; §1–3, §13, §14, §17 corrected to match the code)*
*Last updated: v1.10.10 — 2026-11-04 (§0 PR layout: automated checks vs manual QA; automated checks as a collapsed table in the description, re-run per commit; v1.10.5: no section changes: Import Logs race fix; v1.10.4: §8, §13 single `~` is literal; §21 excerpts escape `~`; v1.10.3: §13 refusals; §21 declined runs; v1.10.2: §13 summary states its dates; §21 per-month derivations; v1.10.1: §13 `AI_MAX_TOKENS`, thinking and cut-off answers; v1.10.0: §21 AI Eval added; §13 `callClaude()` raw mode; v1.9.6: §14 folder access lasts until the last tab closes, not one page load; v1.9.5: §7 chart guard; v1.9.4: views-db.js changelog reads CRLF checkouts; v1.9.3: §14 folder permission: re-request on click, Reconnect banner, browser copy wins; v1.9.2: §0 branch, PR and approval workflow added; v1.9.1: §4.5 rehydrate transactions loaded from JSON; v1.9.0: §20 Data & Reset added; v1.8.1: §10 re-upload dedup rewritten for the occurrence-suffix fix; v1.8.0: AI Analysis restored with API-key and output hardening; `renderMarkdown()` added; `samples/` added; §1–3, §13, §14, §17 corrected to match the code)*

---

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

> A zero-install, browser-native finance dashboard. Drop in your bank CSVs, get instant clarity on your money.

**Version:** v1.10.5 &nbsp;·&nbsp; **Stack:** Vanilla JS, HTML, CSS &nbsp;·&nbsp; **Install:** None
**Version:** v1.10.10 &nbsp;·&nbsp; **Stack:** Vanilla JS, HTML, CSS &nbsp;·&nbsp; **Install:** None

---

Expand Down Expand Up @@ -260,4 +260,4 @@ See [CHANGELOG.md](CHANGELOG.md) for the full release history.

---

*FinLens v1.10.5 — Built for one person's finances, designed to be useful for anyone's.*
*FinLens v1.10.10 — Built for one person's finances, designed to be useful for anyone's.*
2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@
<div style="margin-top:auto">
<a class="nav" data-view="settings">⚙️ Settings</a>
<div class="footer">
<div style="color:var(--text-3);font-size:11px">v1.10.5 · FinLens</div>
<div style="color:var(--text-3);font-size:11px">v1.10.10 · FinLens</div>
</div>
</div>
</aside>
Expand Down
2 changes: 1 addition & 1 deletion js/views-settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ function _renderGeneralSettings(root) {
</select>
</div>
</div>
<div class="muted" style="font-size:11.5px;margin-top:14px">FinLens v1.10.5 ·${State.transactions.length} transactions loaded${State.lastRefresh?' · Refreshed '+dayjs(State.lastRefresh).format('MMM D, YYYY h:mm A'):''}</div>`;
<div class="muted" style="font-size:11.5px;margin-top:14px">FinLens v1.10.10 ·${State.transactions.length} transactions loaded${State.lastRefresh?' · Refreshed '+dayjs(State.lastRefresh).format('MMM D, YYYY h:mm A'):''}</div>`;
root.appendChild(displayCard);

/* ---- Anthropic API Key ---- */
Expand Down