provider: drop dead xhigh branch in NormalizeReasoningEffort - #652
Merged
Conversation
The Settings UI cycles through {low, medium, high, max} and config
defaults to low, so xhigh is never produced by the UI and is only
reachable via a hand-edited config value the surface cannot emit.
NormalizeReasoningEffort now passes unknown tiers through unchanged,
consistent with its handling of every other value.
Fixes #646
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #646.
Summary
Removes the legacy
xhigh→highspecial case inNormalizeReasoningEffort. Unknown reasoning-effort tiers now pass through unchanged, consistent with every other value (low,medium,high,max, ```,bogus).Changes
internal/provider/provider.go: drop thexhighbranch fromNormalizeReasoningEffortinternal/provider/openai_test.go:TestNormalizeReasoningEffortnow assertsxhighpasses through unchangedTestOpenAIEmitsThinkingAndReasoningEffortuses a real tier (high) instead of the removed legacy valueVerification
go build ./...passesgo test ./internal/provider/...passesgo vet ./...passes (the bwrap sandbox test failures ininternal/app/internal/engine/internal/toolsare pre-existing container-privilege limitations, confirmed failing onmain)