tui: reduce mouse-wheel scroll to ~10% of page height per notch - #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #655
Summary
Reduces the transcript history mouse-wheel scroll from
height/3per notch toheight/10(with a minimum of 1 row), making wheel navigation gentle and smooth. A physical wheel rotation emits several notch events, so previously a single flick moved ~3 pages.Changes
internal/tui/transcript.go:mouseWheelRows()now scrollsHeight()/10rows per notch (min 1); updated docs onnavigateMouse.internal/tui/model_scroll_test.go: renamedTestScroll_mouseWheelMovesByThirdPage→TestScroll_mouseWheelMovesTenthOfPage, asserting the new ~10% amount.Behaviour preserved (verified by existing tests)
internal/tuitest suite passesNote:
internal/appandinternal/enginetest failures in this environment are pre-existing onmain(require thebwrapbinary which is not installed) and unrelated to this change.