Fix PHP 8 compatibility in idna_convert - #48
Open
johansolve wants to merge 1 commit into
Open
Conversation
Replace curly-brace string offset syntax (removed in PHP 8.0) with square brackets, and declare the $slast property to avoid the dynamic property deprecation notice (PHP 8.2). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XM4dnVfCghHbjdoCLtzmus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
PHP/api_classes/idna_convert.phprun cleanly on PHP 8.x.$str{$i}), removed in PHP 8.0, with square brackets in four places.$slastproperty to avoid the dynamic property deprecation notice (PHP 8.2).No behavioural change —
encode()verified to still produce correct punycode output.🤖 Generated with Claude Code