Repository navigation
fix(quit): release the window registry outside its borrow (#166) - #167
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing the window with the close button (or Alt+F4) left the window registry borrowed while the last reference was released during shutdown. The
destroyhandler then found theRefCellalready borrowed, the panic could not unwind through C and the process aborted, so every normal window close ended as a crash.The registry is now pruned through a non blocking helper (
try_with+try_borrow_mut) and the window vector is taken out of the thread local before the references are dropped, so the reentry that #141 handled through the TLS destructors is covered here too.Verified with a real window manager: 0.3.30 aborts with SIGABRT (exit 134) on 3 of 3 window closes, the fixed build exits 0 on 3 of 3. The regression test fails if the helper borrows the registry directly instead of using
try_borrow_mut.Closes #166