extended: wrap requestValue as RFC 4511 [1] OCTET STRING - #628
Open
team-humaki wants to merge 1 commit into
Open
team-humaki wants to merge 1 commit into
team-humaki wants to merge 1 commit into
Conversation
appendTo appended the caller BER payload as a bare child of ExtendedRequest, so NMAS/eDirectory rejected the request as "invalid version". Encode requestValue as context-specific tag 1 OCTET STRING holding the serialized payload. Leave packets that are already [1] unchanged so Password Modify-style callers are not double-wrapped. Fixes go-ldap#627 Signed-off-by: Team Humaki <team@humaki.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 4511 encodes
requestValueas context-specific[1] OCTET STRING.ExtendedRequest.appendTowas appending the caller BER payload as a bare child, so NMAS/eDirectory rejected a request that OpenLDAP accepted (NMAS Extension invalid version).Wrap unwrapped payloads as
[1] OCTET STRINGholding the serialized BER. Leave packets that are already context class tag 1 unchanged so Password Modify-style callers are not double-wrapped.Fixes #627