Repository navigation
Take the CI Go version from go.mod - #16
Merged
Merged
Conversation
CI pinned its Go version separately from go.mod. It now reads the major and minor version from the go directive and installs the latest patch release of it. Seven example modules drop their toolchain go1.24.6 line, which specified a suggested toolchain. Their go 1.24.0 line stays: their dependencies declare go 1.24.0, so go mod tidy would restore it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the workflow pinned the Go version in
actions/setup-goseparately fromgo.mod. After this change, CI reads the major and minor version from thegodirective ingo.modand installs the latest patch release of it withcheck-latest: true.go-version-filewould install exactly the patch version written ingo.mod, such as 1.25.0, so it is not used.The resolved version does not change: CI installs the latest Go 1.24 patch release, as before. Seven example modules drop their
toolchain go1.24.6line, which specified a suggested toolchain. Theirgo 1.24.0line stays, because their dependencies declarego 1.24.0andgo mod tidywould restore it.On this branch, setup-go installs Go 1.24.13 and the build passes; the seven example modules build without their
toolchainlines.