Skip to content

Take the CI Go version from go.mod - #58

Merged
umputun merged 1 commit into
masterfrom
ci/go-version-from-go-mod
Nov 1, 2026
Merged

umputun merged 1 commit into
masterfrom
ci/go-version-from-go-mod

Conversation

@paskal

@paskal paskal commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

Previously, the workflow pinned the Go version in actions/setup-go separately from go.mod. After this change, CI reads the major and minor version from the go directive in go.mod and installs the latest patch release of it with check-latest: true. go-version-file would install exactly the patch version written in go.mod, such as 1.25.0, so it is not used. go.mod is unchanged.

The matrix keeps two legs: go.mod, which resolves to the latest Go 1.24 patch release as before, and stable. Linting and coverage still run only on stable.

On this branch, the go.mod leg installs Go 1.24.13 and the stable leg Go 1.27.3; both pass.

Coveralls reports a 0.3% decrease. Coverage is submitted from the stable leg before and after this change; the master baseline was recorded on Go 1.26.6 in August, and stable now resolves to Go 1.27.3.

CI pinned its Go version separately from go.mod. It now reads the major
and minor version from the go directive and installs the latest patch
release of it.

The matrix keeps its stable leg; the other leg now reads go.mod.
@paskal
paskal requested a review from umputun as a code owner November 1, 2026 10:45
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 41298873349

Coverage decreased (-0.3%) to 96.86%

Details

  • Coverage decreased (-0.3%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
secure.go 1 97.85%

Coverage Stats

Coverage Status
Relevant Lines: 1465
Covered Lines: 1419
Line Coverage: 96.86%
Coverage Strength: 41.71 hits per line

💛 - Coveralls

@umputun umputun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@umputun
umputun merged commit 16e1e00 into master Nov 1, 2026
4 of 6 checks passed
@umputun
umputun deleted the ci/go-version-from-go-mod branch November 1, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants