Repository navigation
Update dependencies and CI, keep Go 1.25 - #8
Merged
Merged
Conversation
Updates every required module to its newest release that still builds with Go 1.25. This clears all 16 open Dependabot alerts and 8 of the 10 vulnerabilities govulncheck reports as reachable from this module: - golang.org/x/crypto v0.50.0 -> v0.55.0: SSH advisories, reached via SSHTestContainer.connect and testcontainers DockerContainer.Terminate - golang.org/x/text v0.36.0 -> v0.41.0: infinite loop on invalid input, reached via NewMongoTestContainerE - github.com/moby/go-archive v0.2.0 -> v0.3.3: crafted tar archive can write outside the extraction directory - github.com/klauspost/compress v1.18.5 -> v1.20.3: panic on two-block frames, reached via MongoTestContainer.Close - github.com/moby/sys/user v0.4.0 -> v0.5.0: Dependabot alert Held back because their next release requires Go 1.26: testcontainers-go v0.45.0, golang.org/x/crypto v0.56.0+, x/sys, x/sync, x/text, opentelemetry v1.47.0, gopsutil v4.26.9+, go-winio v0.6.3+. GO-2026-6354 and GO-2026-6355 (SSH DoS on deadlocked channels) remain open for that reason: the fix is in x/crypto v0.56.0.
- setup-go installs the latest patch of the Go version declared in go.mod instead of a hard-coded "1.25", so CI follows the module's minimum Go minor version - checkout v4 -> v7, setup-go v5 -> v7, golangci-lint-action v7 -> v9 (node 24 runtime), golangci-lint v2.6 -> v2.15 - push trigger lists branches and tags as ["**"] instead of empty keys - quote shell variables flagged by actionlint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates every required module to its newest release that still builds with Go 1.25, and brings the CI workflow up to date. This clears all 16 open Dependabot alerts (7 critical). Before this change,
govulncheck ./...reported 10 vulnerabilities reachable from this module's code; after it, 2 remain, as described below.Dependencies
Security-relevant updates:
golang.org/x/cryptoSSHTestContainer.connectand testcontainersDockerContainer.Terminategolang.org/x/textNewMongoTestContainerEgithub.com/moby/go-archivegithub.com/klauspost/compressMongoTestContainer.Close; Dependabot alert GHSA-259r-337f-4rfwgithub.com/moby/sys/userThe other required modules, direct and indirect, move to their newest compatible releases as well;
go.modshows the versions.The
godirective stays at 1.25.0. Held back because their next release requires Go 1.26: testcontainers-go v0.45.0,golang.org/x/cryptov0.56.0+,x/sys,x/sync,x/text, opentelemetry v1.47.0, gopsutil v4.26.9+, go-winio v0.6.3+.CI
go.mod: the workflow reads thegodirective and installs the latest patch of that minor version (check-latest: true), so CI follows the module's minimum Go minor version without a hard-coded version.actions/checkoutv4 -> v7,actions/setup-gov5 -> v7,golangci-lint-actionv7 -> v9 (Node 24 runtime), golangci-lint v2.6 -> v2.15.["**"]instead of empty keys.Not fixed here
GO-2026-6354 and GO-2026-6355 (SSH DoS on deadlocked channels, reached via
SSHTestContainer.connect) are fixed ingolang.org/x/cryptov0.56.0, which requires Go 1.26. Raising the minimum Go version is left for a separate decision.Verification
go test -race ./...with Go 1.25.14 passes, including the Docker-backed container tests.golangci-lint run(v2.15) reports no issues;actionlintreports none for the workflow.govulncheck ./...reports 2 reachable vulnerabilities (the two above), down from 10.