fix: support .MATCH in wildcard include vars#2929
Closed
vmaerten wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2732.
.MATCHwas not usable in thevarsof an include declared with a wildcardnamespace, e.g.:
Running
task stack:prod:deployfailed withindex of untyped nil.The wildcard matching itself already worked: the
*in the include key isconcatenated literally into the merged task name (
stack:*:deploy), andWildcardMatchcaptures it at runtime, soGetTasksetsMATCH=["prod"]incall.Vars. The only problem was ordering inCompiler.getVariables: includevars were templated before
call.Vars(which carriesMATCH) was merged in,so
MATCHwas still nil when the include vars were rendered.This change exposes
MATCHin the accumulator right before include vars areevaluated. It is purely additive — the previous behaviour errored, so no
existing Taskfile can regress.
call.Varsas a whole is intentionally notmoved earlier, to preserve the precedence of vars passed explicitly to
sub-tasks.
Note: only the include's
varscan use.MATCH. Thetaskfileanddirfields are resolved at load/merge time, before any task is called, so no
wildcard has been matched yet — this is documented.
Test plan
TestIncludesWildcardVars(nominal match, second match, no-match error)with fixture
testdata/includes_wildcard_vars/.go test .→ all 499 tests pass, no regression onTestWildcard/TestIncluded*/TestInclude*.task --dir testdata/includes_wildcard_vars stack:prod:deployprints
Deploying to prod.guide.md.