[YOLO-3177] feat(react): add notes prop to Checkout for custom label + placeholder#1412
Open
lalcantara-godaddy wants to merge 1 commit into
Open
[YOLO-3177] feat(react): add notes prop to Checkout for custom label + placeholder#1412lalcantara-godaddy wants to merge 1 commit into
lalcantara-godaddy wants to merge 1 commit into
Conversation
…label & placeholder
🦋 Changeset detectedLatest commit: 7d456d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The checkout notes-collection field renders a fixed label (
t.general.notes→ "Notes") and placeholder (t.shipping.notesPlaceholder→ "Notes or special instructions"), both sourced from localization with no per-checkout override. Consumers that need a custom notes label/placeholder (e.g. pay links surfacing a merchant-configured notes title) had no clean way to set them — the only knobs were the globallocalizationprop orcheckout.form.notes.*target injection, which can't cleanly replace the section header or touch the placeholder.TLDR: Support existing Notes feature for invoices and paylinks
Changeset
Changes
CheckoutProps: new optionalnotes?: { label?: string; placeholder?: string }.CheckoutFormto both<NotesForm />render sites and the standalone notes section header.NotesForm: accepts optionallabel/placeholderprops.label ?? t.general.notesplaceholder ?? t.shipping.notesPlaceholder??(not||) so an explicit empty string renders no placeholder, whileundefinedkeeps the localized default.notes?.label ?? t.general.notes.CheckoutSectionHeaderis unchanged — it already acceptstitle.Backward compatibility
Fully backward compatible. When
notesis omitted (or its fields are undefined), label and placeholder fall back to the existing localization strings — identical to current behavior. No other section is affected.Tests
Added cases to
checkout-validation.test.tsxcovering:label+placeholderrender on the standalone notes field/headerplaceholder→ no placeholder attributeAll notes-UI tests pass (12/12).
Usage
Test Plan
Data: