Repository navigation
Conversation
Member
Author
|
cc @gajjarc |
Member
Author
|
I tried to go out of my way to test that this works with Go 1.11, the oldest supported version according to go.mod, but it turns out this module already doesn't build with 1.11. 🙃 |
prattmic
force-pushed
the
push-kkxtpxyxprpv
branch
from
September 28, 2026 19:48
89f6c09 to
3f2b55a
Compare
In upcoming Go 1.28, the deprecated Transport.CancelRequest has become no-op, causing TestAPICallRPCFailure to timeout because the in-flight request is never canceled. Set the deadline using context.WithTimeout instead, matching the current recommended way of canceling request. Note that this also means that cancelling the context passed to post will cancel the HTTP request, which it previously would not. Creating a context with timeout has a few more allocations than creating a timer + closure, so bump the limits on TestAPICallAllocations. Part of this is due to additional allocations from extending the parent context with an additional timeout. For what it's worth, I'm not convinced that absolute allocation count is the best metric here, given how many dependencies Call has (net/http, protobuf, etc). The v2 version of this test is not failing, but it's at exactly 86, so bump it so the next tiny change doesn't break it.
prattmic
force-pushed
the
push-kkxtpxyxprpv
branch
from
October 1, 2026 16:17
3f2b55a to
7c6d505
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In upcoming Go 1.28, the deprecated Transport.CancelRequest has become no-op, causing TestAPICallRPCFailure to timeout because the in-flight request is never canceled. Set the deadline using context.WithTimeout instead, matching the current recommended way of canceling request.