Skip to content

Make embedded skeleton Clippy-clean - #131

Open
noise64 wants to merge 3 commits into
mainfrom
gol-421-skeleton-clippy
Open

Make embedded skeleton Clippy-clean#131
noise64 wants to merge 3 commits into
mainfrom
gol-421-skeleton-clippy

Conversation

@noise64

@noise64 noise64 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor
  • resolves https://linear.app/golem-cloud/issue/GOL-421/make-the-embedded-skeleton-clippy-clean-and-enforce-it-in-ci
  • adds one failure-safe local and CI Clippy helper covering P2/P3 default and maximal feature lanes with -Dwarnings
  • restores Cargo.toml_ before best-effort artifact cleanup and adds success, early-failure, and late-failure contract coverage
  • fixes the existing skeleton warnings without broad allowances while preserving the SQLite JavaScript bridge ABI and module-loader behavior
  • fixes P3 WebSocket receive/close reentrancy by releasing RefCell ownership before awaiting the host receive
  • documents the shared skeleton lint workflow for contributors and agents

@noise64

noise64 commented Aug 29, 2026

Copy link
Copy Markdown
Contributor Author

Correction SHA 311ef670e2e2df597c7272d9a54c87bfcd6f19b9 is fully green in CI run 33259322804.

The dedicated skeleton-clippy job passed all failure-safe embedded-skeleton lanes, and the build, test-other, P2/P3 runtime, P2/P3 node-compat, and dedicated P3 suites all passed. The initial test-runtime-p3 (2) transport flake passed on rerun without a source change.

Local verification also passed the four-lane helper and confirmed that Cargo.toml_ was restored and generated skeleton artifacts were removed after every lane.

@noise64
noise64 marked this pull request as ready for review August 29, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant