perf(app): isolate answer streaming from the global store - #2
Merged
Conversation
The top-level app component subscribes to the entire store, so the answer typewriter (which wrote each tick into the main store) re-rendered the whole ~8500-line tree up to 24 times per reply, plus on every keystroke elsewhere. Park the in-flight partial text in a dedicated stream store read only by a tiny <StreamingAnswer /> node; the chat message still holds the empty placeholder while streaming and the final text is committed back to the store ONCE at the end. Net: the app tree re-renders twice per answer (push + commit) instead of ~24 times. Behavior is unchanged: same typewriter cadence (24 ticks / 55ms), same final Markdown render, all text paths (server, BYOK, error fallback) and the media path are untouched.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The top-level app component subscribes to the entire store, so the answer typewriter (which wrote each tick into the main store) re-rendered the whole ~8500-line tree up to 24 times per reply, plus on every keystroke elsewhere. Park the in-flight partial text in a dedicated stream store read only by a tiny node; the chat message still holds the empty placeholder while streaming and the final text is committed back to the store ONCE at the end. Net: the app tree re-renders twice per answer (push + commit) instead of ~24 times.
Behavior is unchanged: same typewriter cadence (24 ticks / 55ms), same final Markdown render, all text paths (server, BYOK, error fallback) and the media path are untouched.