fix(academic-research): keep Agent Engine SDK versions in sync - #2256
Open
yaodong-shen wants to merge 1 commit into
Open
fix(academic-research): keep Agent Engine SDK versions in sync#2256yaodong-shen wants to merge 1 commit into
yaodong-shen wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1223.
Summary
The academic-research deployment script now pins the remote Agent Engine runtime to the locally installed
google-cloud-aiplatformandgoogle-adkversions. The Vertex AI requirement also includes theadkextra so the deployment receives the compatible framework integration.This prevents the serialized
AdkAppfrom being deployed with a different ADK API surface, which caused thecanonical_on_model_error_callbackstype error reported in the issue.The README now explains the version-parity requirement, and the deployment requirement builder has a credential-free unit test.
Tests
.venv/bin/pytest -q tests/test_deployment_requirements.py— 1 passed.venv/bin/ruff check deployment/runtime_requirements.py deployment/deploy.py tests/test_deployment_requirements.py.venv/bin/ruff format --check deployment/runtime_requirements.py deployment/deploy.py tests/test_deployment_requirements.py.venv/bin/mypy deployment/runtime_requirements.py tests/test_deployment_requirements.py.venv/bin/codespell README.md deployment/deploy.py deployment/runtime_requirements.py tests/test_deployment_requirements.py.venv/bin/python -m compileall -q deployment/runtime_requirements.py deployment/deploy.py tests/test_deployment_requirements.pyWith the checked-in lock file, the generated requirements are:
A live Agent Engine deployment was not run because it requires a configured GCP project, storage bucket, credentials, and billable cloud resources.