assemble_cvd: Skip rebuilding OS composite disk on snapshot restore - #3143
Open
Elie-Kh wants to merge 1 commit into
Open
assemble_cvd: Skip rebuilding OS composite disk on snapshot restore#3143Elie-Kh wants to merge 1 commit into
Elie-Kh wants to merge 1 commit into
Conversation
When restoring from a snapshot, the base images and instance disks have already been restored from the snapshot directory by RestoreHostFiles(). Checking filesystem timestamps to determine whether to rebuild composite disks during snapshot restore can lead to creating_os_disk becoming true, which causes assemble_cvd to abort with 'Restoring from snapshot requires not creating OS disks'. Only evaluate WillRebuildCompositeDisk() and set creating_os_disk when snapshot_path is empty. Bug: 554545294
Elie-Kh
force-pushed
the
skip_rebuilding_os_disk_on_restore
branch
from
September 4, 2026 16:21
7d8cdd9 to
c148b7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When restoring from a snapshot, the base images and instance disks have already been restored from the snapshot directory by RestoreHostFiles(). Checking filesystem timestamps to determine whether to rebuild composite disks during snapshot restore can lead to creating_os_disk becoming true, which causes assemble_cvd to abort with 'Restoring from snapshot requires not creating OS disks'.
Only evaluate WillRebuildCompositeDisk() and set creating_os_disk when snapshot_path is empty.
Bug: 554545294