feat: add ExecutableNames and InstallPath fields to PkgSpec - #209
Merged
Conversation
Contributor
Author
|
Tested this locally: test.goospec cat /tmp/test.goospec
{
"name": "test-app",
"version": "1.0.0@1",
"arch": "noarch",
"executableNames": ["test.exe", "helper.exe"],
"installPath": "C:\\Program Files\\TestApp"
}installed in a local db /tmp/googet -root "$TEST_ROOT" install -db_only -force ./test-app.noarch.1.0.0@1.goo
Install test-app.noarch.1.0.0@1.goo? (y/N): y
Installing test-app 1.0.0@1...
Installation of test-app completedverified json includes the new fields /tmp/googet -root "$TEST_ROOT" installed --format=json
[
{
"SourceRepo": "",
"DownloadURL": "",
"Checksum": "",
"LocalPath": "/tmp/tmp.JfI10QcEbC/cache/test-app.noarch.1.0.0@1.goo",
"UnpackDir": "",
"PackageSpec": {
"Name": "test-app",
"Version": "1.0.0@1",
"Arch": "noarch",
"Replaces": null,
"Conflicts": null,
"Provides": null,
"Install": {},
"Uninstall": {},
"Verify": {},
"ExternalProgramName": "",
"ExecutableNames": [
"test.exe",
"helper.exe"
],
"InstallPath": "C:\\Program Files\\TestApp"
},
"InstalledFiles": {},
"InstallDate": 1788196085,
"InstalledApp": {
"Name": "",
"Reg": ""
}
}
] |
nguyen-phillip
self-requested a review
August 31, 2026 17:48
r0mflip
self-requested a review
August 31, 2026 20:15
Add `ExecutableNames` and `InstallPath` fields to `PkgSpec` to support identifying application binaries and installation directories. - Add ExecutableNames ([]string) and InstallPath (string) to goolib.PkgSpec - Display InstallPath in goolib.PkgSpec.PrettyPrint - Add unit tests in goolib and persistence tests in googetdb - Bump version to 3.3.3@0 in googet.goospec and add release note
goog-harish
force-pushed
the
goospec-update
branch
from
September 1, 2026 04:00
441d71e to
923004d
Compare
r0mflip
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
ExecutableNamesandInstallPathfields toPkgSpecto support identifying application binaries and installation directories.ExecutableNames([]string) andInstallPath(string) togoolib.PkgSpecInstallPathingoolib.PkgSpec.PrettyPrint3.3.3@0ingooget.goospecand add a release note