Update Room transactions when downloading a survey - #3869
Open
andreia-ferreira wants to merge 3 commits into
Open
Update Room transactions when downloading a survey #3869andreia-ferreira wants to merge 3 commits into
andreia-ferreira wants to merge 3 commits into
Conversation
andreia-ferreira
temporarily deployed
to
e2e-approval
August 4, 2026 21:15 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3866
Fixes #3767
After a survey finishes downloading, saving it locally ran one database transaction per site and then scanned the whole table to prune deleted ones. This caused the initial loading dialog to show for longer than needed, especially for large surveys. This PR improves that by:
upsertAll)deleteNotInand replace with a new dao method to check the relevant ids for a surveygetIds, filtering which ones were dropped, and removing them withdeleteByIdsin chunks within a single transaction.MAX_SQL_VARIABLESto limit size of the chunks to avoid potential crashes ([Crash] IllegalStateException: Couldn't read row, col from CursorWindow on LocationOfInterestDao #3767)@shobhitagarwal1612 PTAL?