Repository navigation
Signal the watch key when its watched directory goes away. - #525
Merged
Merged
Conversation
`PollingWatchService` cancelled the key when the directory could no longer be snapshotted (for example, after it was deleted) but never queued it, so a thread blocked in `WatchService.take()` was never woken up and could not find out that the key was invalid. Signal the key after cancelling it, as the JDK's own polling and Linux watch services do. Compare [the JDK's test for this scenario](https://github.com/openjdk/jdk/blob/4691e9c192cc30c4c08d46632f248c463b3bd48c/test/jdk/java/nio/file/WatchService/Basic.java#L199). Fixes #72 Fixes #524 RELNOTES=n/a PiperOrigin-RevId: 994601353
copybara-service
Bot
force-pushed
the
test_994360781
branch
from
October 6, 2026 20:45
0d76545 to
b014510
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signal the watch key when its watched directory goes away.
PollingWatchServicecancelled the key when the directory could no longer be snapshotted (for example, after it was deleted) but never queued it, so a thread blocked inWatchService.take()was never woken up and could not find out that the key was invalid. Signal the key after cancelling it, as the JDK's own polling and Linux watch services do.Compare the JDK's test for this scenario.
Fixes #72
Fixes #524
RELNOTES=n/a