fix(secops): include entity values in related entities formatter - #280
Open
dandye wants to merge 1 commit into
Open
fix(secops): include entity values in related entities formatter#280dandye wants to merge 1 commit into
dandye wants to merge 1 commit into
Conversation
The lookup_entity formatter was only displaying the entity type for related entities, omitting the actual entity values (IPs, domains, hashes, etc.). This fix adds the entity value to the output alongside the type, providing complete information about related entities in the summary. Changes: - Initialize entity_value default to 'Unknown' - Extract entity.value attribute if available - Update output format to include both value and type
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #268
Problem
The lookup_entity formatter was only displaying the entity type for related entities, omitting the actual entity values (IPs, domains, hashes, etc.).
Solution
Added extraction and display of entity.value alongside entity type for related entities, providing complete information about related entities in the summary.
Changes
Verification