Cache sharding metadata device mesh serialization - #3514
Open
Trighap52 wants to merge 1 commit into
Open
Conversation
Trighap52
marked this pull request as ready for review
August 2, 2026 19:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3494.
This PR deduplicates
NamedShardingMetadatadevice-mesh serialization by caching theDeviceMetadataMeshconversion from a JAX mesh and by caching the serializeddataclasses.asdictoutput for each metadata mesh.Details
NamedShardingMetadata.to_serialized_string()previously calleddataclasses.asdict(self.device_mesh)for every array metadata entry, which repeatedly deep-copied the same device mesh when many arrays shared one mesh.This change:
jax.sharding.MeshhashabilityDeviceMetadataMeshconstruction for repeated equivalent meshescached_propertyValidation
.venv/bin/python checkpoint/orbax/checkpoint/_src/metadata/sharding_test.pyPATH="$PWD/.venv/bin:$PATH" .venv/bin/pre-commit run --files $(git diff --name-only origin/main)