Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Delegates Echo:NuGet to the NuGet ecosystem helper (four-part versions, case-insensitive prereleases). NuGet follows SemVer precedence and ignores build metadata, so like Echo:npm the +echo.N build number is used as a tie-breaker; the Go npm wrapper is generalized to wrap either helper. Echo:NuGet advisories are already in the Echo feed and currently fall through to the dpkg ordering. Signed-off-by: ofrinevo <Ofri.nevo@echo.ai>
ofrinevo
force-pushed
the
echo-nuget-support
branch
from
September 23, 2026 12:42
7727be9 to
9a72502
Compare
ofrinevo
marked this pull request as ready for review
September 23, 2026 13:02
Contributor
|
Hey, @another-rex, we have added Nuget patched libraries and Ofri from our team is contributing the OSV support. |
jess-lowe
pushed a commit
to ossf/osv-schema
that referenced
this pull request
Sep 24, 2026
## Summary Adds `Echo:NuGet` to the supported `:<ECOSYSTEM>` suffixes in the `Echo` ecosystem definition documented in #615. | Ecosystem | Packages | Version ordering | |---|---|---| | `Echo:NuGet` | NuGet | NuGet | Echo now publishes secured builds of NuGet packages, which carry the same `+echo.<N>` build suffix (e.g. `12.0.3+echo.1`). Version ordering support in osv.dev: google/osv.dev#6061. ## Changes Updates the `Echo` entry in `ecosystems.json` and regenerates the list in `docs/schema.md` with `scripts/update-ecosystems-lists.py`. Signed-off-by: ofrinevo <Ofri.nevo@echo.ai> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Extends the Echo ecosystem to support NuGet versioning semantics via the
Echo:NuGetsuffix, so Echo can publish advisories for its secured NuGet packages without affecting the upstream NuGet ecosystem. Follows the existingEcho:PyPI(#5286),Echo:Maven(#5555) andEcho:npm(#5589) handling.Echo:NuGetadvisories are already in the Echo feed. Without this change they fall through to the dpkg ordering, which mis-orders NuGet prereleases (e.g.1.0.0-beta).Details
Echo:NuGetdelegates to the existing NuGet helper, which handles four-part versions (x.y.z.R) and case-insensitive prereleases.12.0.3,12.0.3+echo.1and12.0.3+echo.2would otherwise compare equal. LikeEcho:npm, the+echo.Nbuild number is used as a tie-breaker:12.0.3 < 12.0.3+echo.1 < 12.0.3+echo.2 < 12.0.4.SemverLikeorNuGet.echoSemverEcosystem/echoSemverVersion) is generalized toechoBuildEcosystem/echoBuildVersion, which wraps eithersemverLikeEcosystem(npm) ornugetEcosystem(NuGet). npm behavior is unchanged.Testing
_ecosystems_test.py) and Go (echo_test.go) cases forEcho:NuGet: base NuGet ordering,+echo.Nordering, four-part versions, and+echo.Nbuilds of prereleases.python -m unittest discover osv/ecosystems/ "*_test.py" .(96 tests) andgo test ./osv/ecosystem/...pass; yapf, pylint and golangci-lint are clean.