match genops operands case-sensitively against unsafe strings - #45
Open
abdul-khaliq-khalid wants to merge 1 commit into
Open
match genops operands case-sensitively against unsafe strings#45abdul-khaliq-khalid wants to merge 1 commit into
abdul-khaliq-khalid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_categorize_genops lowercases each operand before matching it, but UNSAFE_STRINGS and the compiled patterns are case-sensitive, so the mixed-case entries (VirtualAlloc, CreateThread, RtlMoveMemory, WaitForSingleObject, Crypto, cProfile, code.InteractiveConsole) never match. A pickle that resolves a global whose name is one of those scores unsafe=0 in the genops scan, and because picklemagic cannot tie the bare name to a known module the whole scan comes back clean on those classic ctypes shellcode primitives. Match the operand as-is, the way strict_security_scan and classify_class_name already do.