sdk/js: cite the js-libp2p issues behind the relay workarounds - #543
Merged
Merged
Conversation
listenThroughRelay reaches the transport manager because js-libp2p has no public way to listen on an address after start(), and keepRelay reserves again because a static relay reservation is not re-established after the connection dropped. Both are filed upstream: libp2p/js-libp2p#3645 and libp2p/js-libp2p#3601. Name them where the code works around them, as the Python SDK does for py-libp2p, so that an upstream fix can be matched to the code it makes unnecessary.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in sdk/README.md and adds comments in sdk/js/src/host.ts and sdk/js/src/session.ts to reference upstream libp2p issues (libp2p/js-libp2p#3645 and libp2p/js-libp2p#3601) related to relay slot reservation and listener behavior. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments and README only.
listenThroughRelayreachescomponents.transportManagerbecause js-libp2p has no public way to listen on an address afterstart();keepRelayreserves again because a static relay reservation is not re-established after the connection dropped. Both are filed upstream:start(), or a hook before RESERVE on a static relayCircuitListen) is never re-established after the relay connection closes libp2p/js-libp2p#3601 — static relay reservation not re-established after the relay connection closesThis names them where the code works around them, as the Python SDK does for py-libp2p#1549 and #1550, so that an upstream fix can be matched to the code it makes unnecessary.