Skip to content

[Raiden/FaultTolerance] Support chunk header version compatibility validation and version-dependent parsing - #993

Open
copybara-service[bot] wants to merge 1 commit into
mainfrom
test_984977310
Open

copybara-service[bot] wants to merge 1 commit into
mainfrom
test_984977310

Conversation

@copybara-service

Copy link
Copy Markdown

[Raiden/FaultTolerance] Support chunk header version compatibility validation and version-dependent parsing

Why:

  • Support rolling upgrades with 1-version backward compatibility before modifying ChunkHeader wire format.
  • v1 and v2 wire formats remain identical in this CL, establishing the versioning infrastructure first so subsequent changes can safely modify wire layouts.

What:

  • Set current version to 2 (kChunkHeaderCurrentVersion = 2) and support incoming versions 1 and 2.
  • Reject unsupported versions (diff >= 2) with FailedPreconditionError.
  • Dispatch incoming deserialization in DeserializeChunkHeader based on version:
    switch (ver) {
      case 1: return DeserializeHeaderV1(h1, header);
      case 2: return DeserializeHeaderV2(h2, header);
      default: return absl::FailedPreconditionError(...);
    }
  • Enforce serializing only current version 2 with DCHECK_EQ(header.version, kChunkHeaderCurrentVersion).

…lidation and version-dependent parsing

Why:
- Support rolling upgrades with 1-version backward compatibility before modifying `ChunkHeader` wire format.
- v1 and v2 wire formats remain identical in this CL, establishing the versioning infrastructure first so subsequent changes can safely modify wire layouts.

What:
- Set current version to 2 (`kChunkHeaderCurrentVersion = 2`) and support incoming versions 1 and 2.
- Reject unsupported versions (diff >= 2) with `FailedPreconditionError`.
- Dispatch incoming deserialization in `DeserializeChunkHeader` based on version:
  ```cpp
  switch (ver) {
    case 1: return DeserializeHeaderV1(h1, header);
    case 2: return DeserializeHeaderV2(h2, header);
    default: return absl::FailedPreconditionError(...);
  }
  ```
- Enforce serializing only current version 2 with `DCHECK_EQ(header.version, kChunkHeaderCurrentVersion)`.
PiperOrigin-RevId: 984977310
@google-cla

google-cla Bot commented Sep 21, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants