Skip to content

fix(samples): pass AccountType enum but use .name property in resource names #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lindsey-volta merged 2 commits into from
Oct 21, 2026
Merged

fix(samples): pass AccountType enum but use .name property in resource names #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49f2575
fix: pass ProductAccount enum but use name property in header constru…
lindsey-volta Oct 21, 2026
ab45306
chore: add valid choices for account type arguments
lindsey-volta Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions samples/audiences/create_user_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,15 +96,15 @@ def main(
headers.append(
(
"login-account",
f"accountTypes/{login_account_type}/accounts/{login_account_id}",
f"accountTypes/{login_account_type.name}/accounts/{login_account_id}",
)
)

if linked_account_id:
headers.append(
(
"linked-account",
f"accountTypes/{linked_account_type}/accounts/{linked_account_id}",
f"accountTypes/{linked_account_type.name}/accounts/{linked_account_id}",
)
)

Expand Down Expand Up @@ -173,7 +173,7 @@ def main(

# Builds the request targeting the parent operating account.
request = datamanager_v1.CreateUserListRequest(
parent=f"accountTypes/{operating_account_type}/accounts/{operating_account_id}",
parent=f"accountTypes/{operating_account_type.name}/accounts/{operating_account_id}",
user_list=user_list,
# Sets validate_only. If true, then the Data Manager API only
# validates the request but doesn't apply changes.
Expand All @@ -197,14 +197,21 @@ def main(
# Configures logging.
logging.basicConfig(level=logging.INFO)

account_type_choices = [
account_type.name
for account_type in datamanager_v1.ProductAccount.AccountType
if account_type
!= datamanager_v1.ProductAccount.AccountType.ACCOUNT_TYPE_UNSPECIFIED
]

parser = argparse.ArgumentParser(
description="Creates a user list in an operating account.",
fromfile_prefix_chars="@",
)
# The following argument(s) should be provided to run the example.
parser.add_argument(
"--operating_account_type",
type=str,
choices=account_type_choices,
required=True,
help="The account type of the operating account.",
)
Expand All @@ -222,7 +229,7 @@ def main(
)
parser.add_argument(
"--login_account_type",
type=str,
choices=account_type_choices,
required=False,
help="The account type of the login account.",
)
Expand All @@ -234,7 +241,7 @@ def main(
)
parser.add_argument(
"--linked_account_type",
type=str,
choices=account_type_choices,
required=False,
help="The account type of the linked account.",
)
Expand Down Expand Up @@ -270,13 +277,21 @@ def main(
args = parser.parse_args()

main(
args.operating_account_type,
datamanager_v1.ProductAccount.AccountType[args.operating_account_type],
args.operating_account_id,
args.validate_only == "true",
datamanager_v1.IngestedUserListInfo.UploadKeyType[args.upload_key_type],
args.login_account_type,
(
Comment thread
jradcliff marked this conversation as resolved.
Resolved
datamanager_v1.ProductAccount.AccountType[args.login_account_type]
if args.login_account_type
else None
),
args.login_account_id,
args.linked_account_type,
(
datamanager_v1.ProductAccount.AccountType[args.linked_account_type]
if args.linked_account_type
else None
),
args.linked_account_id,
(
datamanager_v1.MobileIdInfo.KeySpace[args.key_space]
Expand Down
Loading