Skip to content

chore: Allow for generation to continue as usual... - #15930

Merged
amanda-tarafa merged 4 commits into
googleapis:mainfrom
amanda-tarafa:generation-fixes
Sep 23, 2026
Merged

amanda-tarafa merged 4 commits into
googleapis:mainfrom
amanda-tarafa:generation-fixes

Conversation

@amanda-tarafa

Copy link
Copy Markdown
Contributor

... while we fix several recent issues.

And revert to last released commit. See b/564485466
We don't need to revert the last generated commit because we didn't merge the generation PR. See b/564939395.
These started failing suddenly with no changes from our side. See b/563376582.
@amanda-tarafa
amanda-tarafa requested review from a team as code owners September 23, 2026 02:35

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Bigtable conformance test script to skip additional tests and modifies the pipeline state configuration, blocking automatic generation for certain APIs and setting a next version for another. The review feedback highlights a critical bug in the conformance script where a mismatch between the defined variable returnCode and the exit statement RETURN_CODE could mask test failures. Additionally, it is recommended to avoid using eval when executing the Go tests to improve code safety and readability.

@amanda-tarafa
amanda-tarafa merged commit 8cea005 into googleapis:main Sep 23, 2026
21 checks passed
@amanda-tarafa
amanda-tarafa deleted the generation-fixes branch September 23, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants