[google-cloud-sdk-librarian-dotnet-robot]

Changes in this PR

• Generated Google.Ads.DataManager.V1

[snippet-bot]

Here is the summary of changes.

You are about to add 4 region tags.

• apis/Google.Ads.DataManager.V1/Google.Ads.DataManager.V1.GeneratedSnippets/IngestionServiceClient.IngestUsersRequestObjectAsyncSnippet.g.cs:19, tag datamanager_v1_generated_IngestionService_IngestUsers_async
• apis/Google.Ads.DataManager.V1/Google.Ads.DataManager.V1.GeneratedSnippets/IngestionServiceClient.IngestUsersRequestObjectSnippet.g.cs:19, tag datamanager_v1_generated_IngestionService_IngestUsers_sync
• apis/Google.Ads.DataManager.V1/Google.Ads.DataManager.V1.GeneratedSnippets/IngestionServiceClient.RemoveUsersRequestObjectAsyncSnippet.g.cs:19, tag datamanager_v1_generated_IngestionService_RemoveUsers_async
• apis/Google.Ads.DataManager.V1/Google.Ads.DataManager.V1.GeneratedSnippets/IngestionServiceClient.RemoveUsersRequestObjectSnippet.g.cs:19, tag datamanager_v1_generated_IngestionService_RemoveUsers_sync

---

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

• Refresh this comment

[gemini-code-assist]

Code Review

This pull request introduces the IngestUsers and RemoveUsers APIs (both synchronous and asynchronous) to the IngestionServiceClient in the Google Ads Data Manager V1 library. This includes adding the corresponding request and response models (IngestUsersRequest, IngestUsersResponse, RemoveUsersRequest, and RemoveUsersResponse), a new User message class, and updating the error reasons with TOO_MANY_USERS and INVALID_AD_IDENTIFIER_FOR_ACCOUNT. Additionally, generated code snippets, metadata, and configuration files have been updated to support these new endpoints. I have no feedback to provide as there are no review comments.

[github-actions]

Pull request diff results
Finding changes in Google.Ads.DataManager.V1...
Comparing old and new versions (by source)
Minor changes:
Enum 'ErrorReason' entry 'TooManyUsers' added.
Enum 'ErrorReason' entry 'InvalidAdIdentifierForAccount' added.
Class 'IngestionService.IngestionServiceBase'; method 'Task IngestUsers(IngestUsersRequest request, ServerCallContext context)' added.
Class 'IngestionService.IngestionServiceBase'; method 'Task RemoveUsers(RemoveUsersRequest request, ServerCallContext context)' added.
Class 'IngestionService.IngestionServiceClient'; method 'IngestUsersResponse IngestUsers(IngestUsersRequest request, CallOptions options)' added.
Class 'IngestionService.IngestionServiceClient'; method 'IngestUsersResponse IngestUsers(IngestUsersRequest request, Metadata headers = null, Nullable deadline = null, CancellationToken cancellationToken = null)' added.
Class 'IngestionService.IngestionServiceClient'; method 'RemoveUsersResponse RemoveUsers(RemoveUsersRequest request, CallOptions options)' added.
Class 'IngestionService.IngestionServiceClient'; method 'RemoveUsersResponse RemoveUsers(RemoveUsersRequest request, Metadata headers = null, Nullable deadline = null, CancellationToken cancellationToken = null)' added.
Class 'IngestionService.IngestionServiceClient'; method 'AsyncUnaryCall IngestUsersAsync(IngestUsersRequest request, CallOptions options)' added.
Class 'IngestionService.IngestionServiceClient'; method 'AsyncUnaryCall IngestUsersAsync(IngestUsersRequest request, Metadata headers = null, Nullable deadline = null, CancellationToken cancellationToken = null)' added.
Class 'IngestionService.IngestionServiceClient'; method 'AsyncUnaryCall RemoveUsersAsync(RemoveUsersRequest request, CallOptions options)' added.
Class 'IngestionService.IngestionServiceClient'; method 'AsyncUnaryCall RemoveUsersAsync(RemoveUsersRequest request, Metadata headers = null, Nullable deadline = null, CancellationToken cancellationToken = null)' added.
Class 'IngestionServiceClient'; method 'IngestUsersResponse IngestUsers(IngestUsersRequest request, CallSettings callSettings = null)' added.
Class 'IngestionServiceClient'; method 'RemoveUsersResponse RemoveUsers(RemoveUsersRequest request, CallSettings callSettings = null)' added.
Class 'IngestionServiceClient'; method 'Task IngestUsersAsync(IngestUsersRequest request, CallSettings callSettings = null)' added.
Class 'IngestionServiceClient'; method 'Task IngestUsersAsync(IngestUsersRequest request, CancellationToken cancellationToken)' added.
Class 'IngestionServiceClient'; method 'Task RemoveUsersAsync(RemoveUsersRequest request, CallSettings callSettings = null)' added.
Class 'IngestionServiceClient'; method 'Task RemoveUsersAsync(RemoveUsersRequest request, CancellationToken cancellationToken)' added.
Class 'IngestionServiceClientImpl'; method 'IngestUsersResponse IngestUsers(IngestUsersRequest request, CallSettings callSettings = null)' added.
Class 'IngestionServiceClientImpl'; method 'RemoveUsersResponse RemoveUsers(RemoveUsersRequest request, CallSettings callSettings = null)' added.
Class 'IngestionServiceClientImpl'; method 'Task IngestUsersAsync(IngestUsersRequest request, CallSettings callSettings = null)' added.
Class 'IngestionServiceClientImpl'; method 'Task RemoveUsersAsync(RemoveUsersRequest request, CallSettings callSettings = null)' added.
Class 'IngestionServiceSettings'; property 'CallSettings IngestUsersSettings { get; set; }' added.
Class 'IngestionServiceSettings'; property 'CallSettings RemoveUsersSettings { get; set; }' added.
Class 'IngestUsersRequest' added.
Class 'IngestUsersResponse' added.
Class 'RemoveUsersRequest' added.
Class 'RemoveUsersResponse' added.
Class 'User' added.
Class 'UserReflection' added.

Diff level: Minor

Comparing with previous NuGet package
Checking compatibility for Google.Ads.DataManager.V1 version 1.0.0-beta10
Differences from 1.0.0-beta10
Minor changes:
Enum 'ErrorReason' entry 'TooManyUsers' added.
Enum 'ErrorReason' entry 'InvalidAdIdentifierForAccount' added.
Class 'IngestionService.IngestionServiceBase'; method 'Task IngestUsers(IngestUsersRequest request, ServerCallContext context)' added.
Class 'IngestionService.IngestionServiceBase'; method 'Task RemoveUsers(RemoveUsersRequest request, ServerCallContext context)' added.
Class 'IngestionService.IngestionServiceClient'; method 'IngestUsersResponse IngestUsers(IngestUsersRequest request, CallOptions options)' added.
Class 'IngestionService.IngestionServiceClient'; method 'IngestUsersResponse IngestUsers(IngestUsersRequest request, Metadata headers = null, Nullable deadline = null, CancellationToken cancellationToken = null)' added.
Class 'IngestionService.IngestionServiceClient'; method 'RemoveUsersResponse RemoveUsers(RemoveUsersRequest request, CallOptions options)' added.
Class 'IngestionService.IngestionServiceClient'; method 'RemoveUsersResponse RemoveUsers(RemoveUsersRequest request, Metadata headers = null, Nullable deadline = null, CancellationToken cancellationToken = null)' added.
Class 'IngestionService.IngestionServiceClient'; method 'AsyncUnaryCall IngestUsersAsync(IngestUsersRequest request, CallOptions options)' added.
Class 'IngestionService.IngestionServiceClient'; method 'AsyncUnaryCall IngestUsersAsync(IngestUsersRequest request, Metadata headers = null, Nullable deadline = null, CancellationToken cancellationToken = null)' added.
Class 'IngestionService.IngestionServiceClient'; method 'AsyncUnaryCall RemoveUsersAsync(RemoveUsersRequest request, CallOptions options)' added.
Class 'IngestionService.IngestionServiceClient'; method 'AsyncUnaryCall RemoveUsersAsync(RemoveUsersRequest request, Metadata headers = null, Nullable deadline = null, CancellationToken cancellationToken = null)' added.
Class 'IngestionServiceClient'; method 'IngestUsersResponse IngestUsers(IngestUsersRequest request, CallSettings callSettings = null)' added.
Class 'IngestionServiceClient'; method 'RemoveUsersResponse RemoveUsers(RemoveUsersRequest request, CallSettings callSettings = null)' added.
Class 'IngestionServiceClient'; method 'Task IngestUsersAsync(IngestUsersRequest request, CallSettings callSettings = null)' added.
Class 'IngestionServiceClient'; method 'Task IngestUsersAsync(IngestUsersRequest request, CancellationToken cancellationToken)' added.
Class 'IngestionServiceClient'; method 'Task RemoveUsersAsync(RemoveUsersRequest request, CallSettings callSettings = null)' added.
Class 'IngestionServiceClient'; method 'Task RemoveUsersAsync(RemoveUsersRequest request, CancellationToken cancellationToken)' added.
Class 'IngestionServiceClientImpl'; method 'IngestUsersResponse IngestUsers(IngestUsersRequest request, CallSettings callSettings = null)' added.
Class 'IngestionServiceClientImpl'; method 'RemoveUsersResponse RemoveUsers(RemoveUsersRequest request, CallSettings callSettings = null)' added.
Class 'IngestionServiceClientImpl'; method 'Task IngestUsersAsync(IngestUsersRequest request, CallSettings callSettings = null)' added.
Class 'IngestionServiceClientImpl'; method 'Task RemoveUsersAsync(RemoveUsersRequest request, CallSettings callSettings = null)' added.
Class 'IngestionServiceSettings'; property 'CallSettings IngestUsersSettings { get; set; }' added.
Class 'IngestionServiceSettings'; property 'CallSettings RemoveUsersSettings { get; set; }' added.
Class 'IngestUsersRequest' added.
Class 'IngestUsersResponse' added.
Class 'RemoveUsersRequest' added.
Class 'RemoveUsersResponse' added.
Class 'User' added.
Class 'UserReflection' added.

Diff level: Minor

Finished comparisons for Google.Ads.DataManager.V1

[robertvoinescu-work]

LGTM