chore(Auth): move the auth library to the mono repo. - #9514
Closed
Hectorhammett wants to merge 609 commits into
Closed
chore(Auth): move the auth library to the mono repo.#9514Hectorhammett wants to merge 609 commits into
Hectorhammett wants to merge 609 commits into
Conversation
Hectorhammett
force-pushed
the
move-auth
branch
from
September 2, 2026 22:32
b833c3e to
626fed2
Compare
bshaffer
reviewed
Sep 3, 2026
bshaffer
left a comment
bshaffer
left a comment
Contributor
There was a problem hiding this comment.
Only one change that i can see outside the Auth repo. I'll continue my review in the auth PR for the changes made there.
| @@ -38,7 +38,7 @@ public function determineImplementingClasses(array $pageNodes): void | |||
| { | |||
| // Project root components | |||
| $componentDirs = array_map('realpath', glob(__DIR__ . '/../../../../*/src', GLOB_ONLYDIR)); | |||
| $componentDirs[] = realpath(__DIR__ . '/../../../vendor/google/auth'); | |||
| $componentDirs[] = __DIR__ . '/../../../vendor/google/cloud/Auth/src'; | |||
Contributor
There was a problem hiding this comment.
Just remove this line - we don't need to manually add auth anymore, it will be loaded with the rest of the components
Suggested change
| $componentDirs[] = __DIR__ . '/../../../vendor/google/cloud/Auth/src'; |
Collaborator
Author
|
Closing this PR as this served as a basis for this one: The new PR has a completely clean and rewritten story and should be ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are making an effort to move all of our libraries into the mono repo.
This depends on:
googleapis/google-auth-library-php#683
This PR should basically mirror all the changes done on the auth library PR to keep the history clean.