fix(Bigtable): use hardcoded client config - #9625
Merged
Merged
Conversation
product-auto-label
Bot
added
the
api: bigtable
Contributor
|
@bshaffer Could we merge this pull request after the migration? I will update |
bshaffer
added
the
do not merge
bshaffer
removed
the
do not merge
Hectorhammett
approved these changes
Sep 9, 2026
Contributor
|
I'll update librarian.yaml to reflect the change. |
JoeWang1127
added a commit
to googleapis/librarian
that referenced
this pull request
Sep 10, 2026
#7549) The `skip_grpc_service_config` option is removed from PHPAPI and the configuration schema. Bigtable now supports gRPC service configuration, so this temporary workaround is no longer needed. This config is removed in google-cloud-php via googleapis/google-cloud-php#9625. Code generation in internal/librarian/php now unconditionally searches for gRPC service config files, and the corresponding unit tests in generate_test.go have been updated. Fixes #7436
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix the failing conformance tests in #9601 by keeping a copy of the previous gRPC config in the handwritten layer and configuration that version instead.