feat(generator): gapic generator centralization mtls#17818
Open
hebaalazzeh wants to merge 6 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors mTLS configuration and client certificate source logic into a new compatibility template _compat.py.j2 to support older versions of google-api-core, updating client.py.j2 and unit tests accordingly. Feedback suggests using the imported mtls module directly in the test template's hasattr check to avoid a potential NameError, and notes that the generated golden files should be regenerated to ensure they are fully in sync with the updated templates.
hebaalazzeh
force-pushed
the
feat/gapic-generator-centralization-mtls
branch
from
July 21, 2026 23:14
1d81ba9 to
3cc6389
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the generator templates to rely on the centralized MTLS fallback logic from
google-api-core.Since the MTLS helpers (
use_client_cert_effective,get_client_cert_source,read_environment_variables) are being centralized intogoogle/api_core/gapic_v1/config.pyin the linkedapi-corePR, we no longer need the generator to produce fallback implementations for them. The generated_compat.pywill now import these directly fromconfig.py.Depends on the
api-coreMTLS centralization PR.related pr: #17817