Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
**PLEASE READ THIS ENTIRE MESSAGE**

Hello, and thank you for your contribution! Please note that this repository is
a read-only split of `googleapis/google-cloud-php`. As such, we are
unable to accept pull requests to this repository.

We welcome your pull request and would be happy to consider it for inclusion in
our library if you follow these steps:

* Clone the parent client library repository:

```sh
$ git clone git@github.com:googleapis/google-cloud-php.git
```

* Move your changes into the correct location in that library. Library code
belongs in `Grafeas/src`, and tests in `Grafeas/tests`.

* Push the changes in a new branch to a fork, and open a new pull request
[here](https://github.com/googleapis/google-cloud-php).

Thanks again, and we look forward to seeing your proposed change!

The Google Cloud PHP team
3 changes: 0 additions & 3 deletions .github/release-please.yml

This file was deleted.

57 changes: 0 additions & 57 deletions .github/workflows/tests.yml

This file was deleted.

10 changes: 9 additions & 1 deletion composer.json
Comment thread
Hectorhammett marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,20 @@
},
"require-dev": {
"guzzlehttp/guzzle": "^7.4||^8.0",
"phpspec/prophecy-phpunit": "^2.0",
"phpspec/prophecy-phpunit": "^2.2",
"phpunit/phpunit": "^9.5",
"psr/cache": "^2.0||^3.0",
"psr/http-client": "^1.0",
"psr/http-factory": "^1.0",
"phpfastcache/phpfastcache": "^9.2",
"phpseclib/phpseclib": "~3.0"
},
"extra": {
"component": {
"id": "jwt",
"target": "googleapis/php-jwt.git",
"path": "Jwt",
"entry": "README.md"
}
}
}
3 changes: 2 additions & 1 deletion src/JWK.php
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,8 @@ private static function createPemFromModulusAndExponent(
* DER-encode the length
*
* DER supports lengths up to (2**8)**127, however, we'll only support lengths up to (2**8)**4. See
* {@link http://itu.int/ITU-T/studygroups/com17/languages/X.690-0207.pdf#p=13 X.690 paragraph 8.1.3} for more information.
* {@link http://itu.int/ITU-T/studygroups/com17/languages/X.690-0207.pdf#p=13 X.690 paragraph 8.1.3}
* for more information.
*
* @param int $length
* @return string
Expand Down
6 changes: 4 additions & 2 deletions src/JWT.php
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ class JWT
* @throws UnexpectedValueException Provided JWT was invalid
* @throws SignatureInvalidException Provided JWT was invalid because the signature verification failed
* @throws BeforeValidException Provided JWT is trying to be used before it's eligible as defined by 'nbf'
* @throws BeforeValidException Provided JWT is trying to be used before it's been created as defined by 'iat'
* @throws BeforeValidException Provided JWT is trying to be used before it's
* been created as defined by 'iat'
* @throws ExpiredException Provided JWT has since expired, as defined by the 'exp' claim
*
* @uses jsonDecode
Expand Down Expand Up @@ -313,7 +314,8 @@ public static function sign(
*
* @param string $msg The original message (header and body)
* @param string $signature The original signature
* @param string|OpenSSLAsymmetricKey|OpenSSLCertificate $keyMaterial For Ed*, ES*, HS*, a string key works. for RS*, must be an instance of OpenSSLAsymmetricKey
* @param string|OpenSSLAsymmetricKey|OpenSSLCertificate $keyMaterial For Ed*, ES*, HS*, a string key works.
* for RS*, must be an instance of OpenSSLAsymmetricKey
* @param string $alg The algorithm
*
* @return bool
Expand Down
3 changes: 1 addition & 2 deletions src/Key.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ public function __construct(
#[\SensitiveParameter] private $keyMaterial,
private string $algorithm
) {
if (
!\is_string($keyMaterial)
if (!\is_string($keyMaterial)
&& !$keyMaterial instanceof OpenSSLAsymmetricKey
&& !$keyMaterial instanceof OpenSSLCertificate
) {
Expand Down
Loading
Loading