feat: add People's Cathedral Primary School to primary schools list - #647
Open
IsaiahSama wants to merge 1 commit into
Open
feat: add People's Cathedral Primary School to primary schools list#647IsaiahSama wants to merge 1 commit into
IsaiahSama wants to merge 1 commit into
Conversation
Adds the missing People's Cathedral Primary School to the primarySchools list used by the Primary School Textbook Grant application form. Closes #646 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing People's Cathedral Primary School to the
primarySchoolslist insrc/data/schools.ts. The entry is placed alphabetically betweenNew Horizon AcademyandReynold Weekes Primary School.The
valueslug follows the existing convention (lowercase, apostrophes/periods stripped, spaces → hyphens — matching e.g.st-margarets-primary-school).Verification
The Primary School Textbook Grant form is correctly wired to this list — no hardcoded school source. The chain is:
src/data/schools.ts→ exportsprimarySchoolssrc/schema/primary-school-textbook-grant.ts:9→ importsprimarySchools, uses it asoptionsfor the "Name of institution" field (line 110)src/components/forms/primary-school-textbook-grant-form.tsx→ renders the schema viaDynamicMultiStepFormsrc/lib/form-registry.ts→ registersget-a-primary-school-textbook-grantSo the new school automatically appears in the textbook grant school dropdown.
Closes #646
🤖 Generated with Claude Code