Skip to content

fix(landing): clean up state persistence and dependencies - #2107

Open
phrogwrld wants to merge 1 commit into
mainfrom
fix/landing-state-dependency-cleanup
Open

fix(landing): clean up state persistence and dependencies#2107
phrogwrld wants to merge 1 commit into
mainfrom
fix/landing-state-dependency-cleanup

Conversation

@phrogwrld

Copy link
Copy Markdown
Contributor

Summary

  • keep StormReady checklist state updaters pure and persist hydrated state safely
  • remove unnecessary FeedbackForm hydration work, markdown plugin barrel imports, dead exports, and unused direct dependencies
  • move pure helpers to module scope and add focused regression coverage
  • update the Nitro Vite configuration shape while preserving runtime configuration
  • document generated-code exclusions and verified framework exceptions

Verification

  • pnpm --filter @govtech-bb/landing lint
  • pnpm --filter @govtech-bb/landing typecheck
  • pnpm --filter @govtech-bb/landing test (27 files, 238 tests)
  • pnpm --filter @govtech-bb/landing build

@github-actions

Copy link
Copy Markdown

Amplify PR previews

App Status URL
forms ✅ Ready https://fix-landing-state-dependency-cleanup.d1j7z1k0h7u5nb.amplifyapp.com
landing ✅ Ready https://fix-landing-state-dependency-cleanup.d3kbl8o0ovutw4.amplifyapp.com
chat ✅ Ready https://fix-landing-state-dependency-cleanup.d3snq1f0c10466.amplifyapp.com
form-builder ✅ Ready https://fix-landing-state-dependency-cleanup.d16oo4n0w76zwn.amplifyapp.com
analytics ✅ Ready https://fix-landing-state-dependency-cleanup.d363pae4e63dc6.amplifyapp.com

Commit: f4f1db2 · Branches auto-delete when this PR closes.

ℹ️ feature-flagging uses a single shared preview slot at a fixed URL (preview.feature-flagging.sandbox.alpha.gov.bb) — GitHub login works, but only one FF preview exists at a time (the most recent FF PR build wins). It reads/writes sandbox flag data.

@amazon-inspector-n-virginia

Copy link
Copy Markdown

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-n-virginia

Copy link
Copy Markdown

✅ I finished the code review, and didn't find any security or code quality issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant