Migrate client to Kotlin/JVM with Java 8 runtime compatibility - #7
Draft
gradwahl wants to merge 1 commit into
Draft
Migrate client to Kotlin/JVM with Java 8 runtime compatibility#7gradwahl wants to merge 1 commit into
gradwahl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Convert the client from Java to Kotlin/JVM while preserving compatibility with a Java 8 runtime.
First migration batch
jvmTarget = 1.8(Java 8 class-file version 52).IsaacCipher,PacketBuffer,Protocol, andLoginResultto Kotlin.Validation performed
javapreports class-file major version 52.--release 8successfully accesses the migrated API.Important migration state
This PR is intentionally a draft. The repository is not yet fully Java 8 runnable because remaining Java files still contain Java 17-era syntax and Maven must temporarily compile those Java sources as Java 17. The final migration step will switch the Java compiler target to 8 (or remove Java compilation entirely) after the remaining
.javafiles are converted and Java 9+ API usages are removed/replaced.Next batches
Convert the remaining packages incrementally, prioritising Java 17-only constructs (
record, switch expressions, etc.), then run a full Java 8 compatibility pass over library/API usage and packaging.