Fix trailing comma in compress SQL - #69
Open
wklimowicz wants to merge 1 commit into
Open
wklimowicz wants to merge 1 commit into
wklimowicz wants to merge 1 commit into
Conversation
Remove the trailing comma before the compression CTE FROM clause and add a sql_only regression test.
wklimowicz
force-pushed
the
fix/compress-sql-trailing-comma
branch
from
August 19, 2026 06:21
0642ff3 to
1849f8d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the progress on this project! The 3+ fixed effects are super fast for me now, and I can run them from R in Databricks.
I've come across this bug in Spark SQL: apparently duckdb is permissive on this but Spark errors out.
Summary
FROMclausesql_onlyregression coverage for the compress strategyTesting
Rscript -e 'tinytest::test_all()'